Merged
Conversation
Documentation preview |
… into torch/track-schema
| module._output_shapes[key] = value.shape | ||
| module._output_dtypes[key] = value.dtype | ||
| else: | ||
| module._output_shapes["output"] = output.shape |
Contributor
There was a problem hiding this comment.
this "output" key is for the case where a module outputs a single tensor? Would something that uses this output schema depend on the name of this column name elsewhere?
Contributor
Author
There was a problem hiding this comment.
Good question, not sure actually. Maybe we should extract it in a constant somewhere?
oliverholworthy
approved these changes
May 25, 2023
26 tasks
29 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals ⚽
This PR introduces
SchemaTrackingMixin, a mixin class for PyTorch modules to track the output shapes and dtypes of the forward pass. This is used in order to automatically generate the output-schema. It registers a hook to capture this information and provides methods to access the output schema.